Patch: Improved notification preview

Yep, after reboot the update continues as it should, thanks.

edit: after update it still shows the patch as installed, and it can't be removed. What has changed though is that it actually works. After.13 update it did not work, it could not be uninstalled. Now it just canät be uninstalled :)

saba

Fri, 2018/03/02 - 15:03

I get "Failed to remove patch" when i try to unapply it. even uninstalling it stays in the patch manager and can't be removed

Sat, 2018/03/03 - 00:17

When did this start happening? Did you update the system without unapplying the patch, which should not be done under any circumstances?

Noerde

Fri, 2018/06/01 - 09:43

Hi, another update, another problem.

The problem remains the same, the patch can't be uninstalled, it remains in patchmanager list as enabled and when unapplying it I only get "failed to remove patch"

if I try:

/usr/sbin/patchmanager -u sailfishos-patch-improved-notification-preview

from command line I get

/usr/sbin/patchmanager -u sailfishos-patch-improved-notification-preview
[D] unknown:0 - "sailfishos-patch-improved-notification-preview ausmt-sailfishos-1\n"

I've tried to rename /usr/share/jolla-settings/pages/sailfishos-patch-improved-notification-preview directory to "force" the removal but it seems to be still in some internal log in patchmanager or something. Is there a way to "nuke" patchmanager from the system and remove all the traces so I could try again?

I think it began when for some reason unapply all patches when upgrading did not work when I did an upgrade in january or thereabouts.

Fri, 2018/06/01 - 12:06

Yes, you should always check that "unapply all patches" does its job properly. It has failed me a few times.

Does your notification preview show as it does normally without this patch? If so, I believe following steps should fix the problem

Remove files "/usr/share/jolla-settings/entries/sailfishos-patch-improved-notification-preview.json" and "/usr/share/jolla-settings/pages/sailfishos-patch-improved-notification-preview/main.qml" if they exist in the system.
In "/var/lib/patchmanager/ausmt/control/" open each file with a text editor and remove lines that mention the patch name, either of those files mentioned in previous section or "NotificationPreview.qml".
Remove sailfishos-patches-improved-notification-preview directory and its content from "/var/lib/patchmanager/ausmt/patches".

Now the patch should appear disabled. Do notice that the current version does not work with 2.2.x. Updated patch will be out soon.

Noerde

Fri, 2018/06/01 - 16:39

Just to let you know the above worked and there's no trace of the patch anymore. I'll install the new version when it's available. Thanks!

alina

Thu, 2017/11/09 - 12:18

Wow, great update!

Fri, 2017/11/03 - 12:21

Hallo Ingvix, i can install the newest version but if i want to apply the patch in patchmanager it failed. I am on 2.1.0.11 lijoki. Any ideas.

Fri, 2017/11/03 - 14:42

I'm not sure. Did a previous version work? Do you have developer mode enabled and are you familiar with terminal?

Fri, 2017/11/03 - 18:28

Yes, 0.3-1 works for me. Developer mode is enabled,but i´m not very familiar with terminal. But we can try it.

Fri, 2017/11/03 - 19:31

Well, there's maybe no need to use terminal if you have a file browser that can access the system folders. Try to enable the patch once more and then copy the last logging in the file "/var/lib/patchmanager/ausmt/ausmt.log" starting where it says

sailfishos-patch-improved-notification-preview
  contains text patch

and paste it to Pastebin.

Sat, 2017/11/04 - 00:55

I paste it to Pastebin ( Search : Sailfish OS - improved-notification-preview )

(edit: https://pastebin.com/fT8WfDSD )

Hope you will find it. Good luck and sail on.

Sat, 2017/11/04 - 01:03

Well, eh, you could've just linked the pastebin page to your comment but I found it anyway. Could you also paste the beginning of the file '/usr/share/lipstick-jolla-home-qt5/notifications/NotificationPreview.qml'? Only the import statements before "SystemWindow". It's a short list so you just paste it to the comment. With that I should be able to fix it.

Sat, 2017/11/04 - 01:19

OK. I do my very best. here it is.

pastebin.com/ayc9B7qf

hope it works

Sat, 2017/11/04 - 14:55

Bit more than I requested but that doesn't matter. I got what I needed and uploaded a new release with a fix. Try and see if it works.

Sat, 2017/11/04 - 16:03

Thanks Ingvix,now I was able to install the new version and apply it in patchmanager. But i am unable to open it in settings and it shows me no notification anymore.:-(

Sat, 2017/11/04 - 16:46

I figured out the problem and the new release should solve it. Try and see.

Sat, 2017/11/04 - 17:34

The new release solved the problem. Thanks Ingvix. You are a hero. I like the patch very much.

Sat, 2017/11/04 - 17:36

You're very welcome.

naytsyrhc

Mon, 2017/10/16 - 20:14

I really love this patch. Notifications look so much better and as they should have looked from the beginning. Thanks a lot!

Mon, 2017/10/16 - 20:35

You're very welcome.

olf

Fri, 2017/10/13 - 23:10

Wow @Ingfx, the customisations "Patch: Improved notification preview" v0.4 provides are incredibly cool!

I almost had trouble to decide between the many choices it offers now, but even that is quite easy with the ability to preview the notification preview look with the top pulley in its settings entry.

Two suggestions came to my mind playing and enjoying it:

IMHO its settings entry should be called "Notification preview" (instead of just "Notification"), as that is what it is all about.
If it is technically feasible, a setting for the duration a notification preview is displayed would make your Patch even more perfect.

Thank you so much for this extremely useful and nice looking improvement of the SailfishOS GUI!

Fri, 2017/10/13 - 23:40

I was sort of thinking that Notification could be the page's main subject in case there'd be some settings for notification in general by someone in the future or something like that. Though it might've been a bit too precautious of me. If that kind of case would present itself I could just update my patch to match it. So I guess I'll change the settings entry to Notification preview for the time being as you suggested.

The preview's duration setting can be implemented quite easily. I'll do it for the next release.

olf

Wed, 2017/10/18 - 02:01

Kudos, as you created the 0.4.1 release incredibly quick and ... it's incredibly cool!

alina

Tue, 2017/08/08 - 23:27

Very well implemented. However I prefer that the direction won't be important for the action, i.e. swiping to both left and right will do the same thing and we will have an additional swipe to top e.g. for deletion.

Wed, 2017/08/09 - 11:47

I will see if I can implement optional swipe directions for different actions in the next release.

MoritzJT

Sun, 2017/08/06 - 19:34

Could you give your patch a few options about width and what it derives from?

Best patch in a while! I disliked those non dismissable obstructions...

Wed, 2017/08/09 - 11:42

Yes, settings are on to-do list.

olf

Fri, 2017/07/28 - 01:52

This seems to be a small bug, when determining the width of a notification preview:
When the first ("title") line is longer than the second line (which is rarely the case), it is still truncated and "fades out" near the right edge. It looks, as if the width of a notification preview is solely calculated based on the second ("Details") line; but when the first line is longer, IMO its width should be used instead of the width of the second line.

Fri, 2017/07/28 - 10:37