Patch: Improved notification preview

Rating: 
4.714285
Your rating: None Average: 4.7 (14 votes)

Moves a bit enlarged icon inside the notification bubble and provides settings to customize notification preview's look and behavior.

You can determine

  • Style of the preview
  • Margin and corner radius (if selected style permits)
  • Maximum and minimum width
  • Duration which the preview is shown
  • What tapping  the preview and swiping it left, right and/or down does.

No more waiting for notifications to time-out out of the way or gathering useless notifications to the events view.

Currently, removing does not work with email notifications. It has probably something to do with notification's email address headers as normally the header is the app's name.

Requires Patchmanager.

You can help translate the patch to your own language on Transifex.

Donations are welcome:

Screenshots: 
Changelog: 

* Tue Nov 6 2018 0.4.4-2

  • Fix for Sailfish 3
  • Updated Spanish translation

* Mon Oct 15 2018 0.4.4-1

  • Content margins setting
  • German translation, thanks to sail_parleur

* Mon Jun 25 2018 Thaodan <theodorstormgrade@gmail.com> 0.4.3-2 (Reverted a bit for familiarity)

  • move changelog to seperate file (recommended by Packaging/Guidelines)
  • fix building in clean build environment, because qmake5 was not installed (missing qt5-qtcore)
  • Added URL tag as suggested by rpmlint-- Shortened Summary as suggested by rpmlint

-* Fri Jun 1 2018 0.4.3-1

  • Fix for 2.2.0.29

* Fri Feb 23 2018 0.4.2-2

  • French and Russian translations, thanks to Guesnery and Ancelad

* Fri Feb 23 2018 0.4.2-1

  • Fix for 2.1.4.13

* Sat Nov 4 2017 0.4.1-4

  • Fix for 2.1.0.11 (and possibly earlier versions)

* Fri Nov 2 2017 0.4.1-2

  • Spanish translation, thanks to Caballlero

* Mon Oct 16 2017 0.4.1

  • Duration setting
  • Small fixes

* Fri Oct 13 2017 0.4

  • Settings page with lot of customation options
  • Bugfixes

* Tue Jul 25 2017 0.3

  • Soft corner only if it doesn't face the side of the screen
  • Notification preview's width is determined by the body text
  • Mimimum preview width is 80% of the portrait-screen-width
  • Maximum is full screen width

* Sat Jul 15 2017 0.2

  • Changed patch for overall notification preview improvement patch.
  • Portrait-screen-wide notification
  • Icon moved inside notification bubble and enlarged
  • Reduced the margins restricting preview texts a bit

* Sat Jul 15 2017 0.1

  • First build.

Comments

feldbaum's picture

I paste it to Pastebin ( Search : Sailfish OS - improved-notification-preview )

(edit: https://pastebin.com/fT8WfDSD )

Hope you will find it. Good luck and sail on.

Ingvix's picture

Well, eh, you could've just linked the pastebin page to your comment but I found it anyway. Could you also paste the beginning of the file '/usr/share/lipstick-jolla-home-qt5/notifications/NotificationPreview.qml'? Only the import statements before "SystemWindow". It's a short list so you just paste it to the comment. With that I should be able to fix it.

feldbaum's picture

OK. I do my very best. here it is.

pastebin.com/ayc9B7qf

hope it works

Ingvix's picture

Bit more than I requested but that doesn't matter. I got what I needed and uploaded a new release with a fix. Try and see if it works.

feldbaum's picture

Thanks Ingvix,now I was able to install the new version and apply it in patchmanager. But i am unable to open it in settings and it shows me no notification anymore.:-(

 

Ingvix's picture

I figured out the problem and the new release should solve it. Try and see.

feldbaum's picture

The new release solved the problem. Thanks Ingvix. You are a hero. I like the patch very much.

Ingvix's picture

You're very welcome.

naytsyrhc's picture

I really love this patch. Notifications look so much better and as they should have looked from the beginning. Thanks a lot!

Ingvix's picture

You're very welcome.

olf's picture

Wow @Ingfx, the customisations "Patch: Improved notification preview" v0.4 provides are incredibly cool!

I almost had trouble to decide between the many choices it offers now, but even that is quite easy with the ability to preview the notification preview look with the top pulley in its settings entry.

Two suggestions came to my mind playing and enjoying it:

  1. IMHO its settings entry should be called "Notification preview" (instead of just "Notification"), as that is what it is all about.
  2. If it is technically feasible, a setting for the duration a notification preview is displayed would make your Patch even more perfect.

Thank you so much for this extremely useful and nice looking improvement of the SailfishOS GUI!

Ingvix's picture

I was sort of thinking that Notification could be the page's main subject in case there'd be some settings for notification in general by someone in the future or something like that. Though it might've been a bit too precautious of me. If that kind of case would present itself I could just update my patch to match it. So I guess I'll change the settings entry to Notification preview for the time being as you suggested.

The preview's duration setting can be implemented quite easily. I'll do it for the next release.

olf's picture

Kudos, as you created the 0.4.1 release incredibly quick and ... it's incredibly cool!

alina's picture

Very well implemented. However I prefer that the direction won't be important for the action, i.e. swiping to both left and right will do the same thing and we will have an additional swipe to top e.g. for deletion.

Ingvix's picture

I will see if I can implement optional swipe directions for different actions in the next release.

MoritzJT's picture

Could you give your patch a few options about width and what it derives from?

Best patch in a while! I disliked those non dismissable obstructions...

Ingvix's picture

Yes, settings are on to-do list.

olf's picture

This seems to be a small bug, when determining the width of a notification preview:
When the first ("title") line is longer than the second line (which is rarely the case), it is still truncated and "fades out" near the right edge. It looks, as if the width of a notification preview is solely calculated based on the second ("Details") line; but when the first line is longer, IMO its width should be used instead of the width of the second line.

Ingvix's picture

Yes, the width is currently only determined by the body which usually is the longer text. I can fix that in next release.

olf's picture

Thanks, that would be nice.
And take your time, as this is a really minor flaw (which rarely occurs).

naytsyrhc's picture

This is really a very nice improvement. For me the notifications now look more integrated and more "sailfish-like" than before. As if the look should have been like that from the beginning. I'd suggest to make something like a "pull request" on sailfish sources in order to get that into official system without patch. Well done and many thanks!

Ingvix's picture

The sharp corners are like that by design as said in the changelog. The round corners were the reason I didn't like it anchored to the right so I though I could make the corners facing the screen sides sharp so they seem attached to the sides.

I was thinking of making the remaining soft corner more round but did not end up doing it at least for this release. It's true that it would increase the distinctiveness from the others so you wouldn't think so easily what you just did, that part of the preview would be left out of the screen. And look better in general too. Maybe I try to create some setting for the next release so every one could make the preview just like they want to.

olf's picture

After using "Improved notification preview" for a while and reconsidering the layout options, I absolutely concur with your current (as of v0.3-1) design choices, especially WRT:

  • No "bubble style" (contrary to Jolla's original notification preview) by omitting the top and left spaces between notification preview and screen border; otherwise that consumes space, which is not available for the notification content, i.e. forcing a smaller font size (as in Jolla's original notification preview), being detrimental to the goal of improved readability.
  • The logical consequence of this is "Soft corner only if it doesn't face the side of the screen", as having all four corners "soft" / round would look awkward without a small spacing between preview and screen borders.

Thus the only remaining layout suggestion I still have is to make the single "soft corner" a bit "rounder" (i.e. to increase its radius), as you already considered.

Side note: While having a look at Jolla's original notification preview on somebody else's SailfishOS device a few days ago, the vast improvement in readability and much better look of your "Improved notification preview" (which I already gotten used to so much, that I only faintly remembered the original) became immediately apparent.
Kudos to you for this!

olf's picture

Oops, did not see this message from you until now (should have reloaded page in browser) and updated my last message below, meanwhile.

No, there is no need for a settings page, which needs efforts to create and maintain, while IMO being unnecessary for a small Patch / UI change like this.

Look, IMHO *this* discussion thread is defining the (one and only) settings for "Improved notification preview": Anyone can criticise your design decisions (like I did), discuss with you, try to convince you with reasonable arguments, ... but ultimately you decide (as "Improved notification preview" is your baby). This process sets the look & feel, and has IMO already resulted in a balanced design.

fravaccaro's picture

I don't want to sound rude, but why would there be no need for a settings page? You're ok with 0.3, I was ok with 0.2 (no, I don't like the new left-anchored design) and the author himself couldn't make up his mind between a couple of different design choices (namely landscape width, margins and corners).
So, assuming he's up for it (as I stated I'd be glad to help), the patch could only benefit from a settings page.

fravaccaro's picture

I'm not sure rounded corners would fit tho, assuming Ingvix wants to follow the remorse pop-up look

Ingvix's picture

I sort if like it with the round corners after all. I'm not really going fo the remorse pop-up look but just a more practical and aestetic on the side if possible. If I was enough experienced I could make a setting page so you can select your own look but maybe in the future.

fravaccaro's picture

Settings page is doable by using ConfigurationGroup. E.g. for the corner radius, instead of a fixed value you put the name of the dconf key which can be changed via a jolla-settings plugin (it is a pretty standard qml page installed in a specific path).

Ingvix's picture

I tried to use it before in another project but I couldn't figure out how to create a new dconf key for my needs. Guess I need to look again.

fravaccaro's picture

I don't know a lot but it works for my needs :) if you need any help you can pm me

Pages