Patch: Returns pulley menu to email view

Markkyboy's picture
Submitted by Markkyboy on Mon, 2020/10/26 - 19:01
Rating: 
5
Your rating: None Average: 5 (9 votes)

**Version 0.1-2 fixes the delete mail problem when in mail view**

**Version 0.1-3 fixes the blanking/fading problem with main view**

Built for Jolla1, tested only on Jolla1 3.4.0.24 Pallas

As per a discussion on SFO, some people don't like the new UI for viewing emails, especially the 'Android' like buttons and the loss of the pulley menu, this patch fixes that, but ONLY in the email view. You will still see the 'buttons on bar' in some views of the email client, like when deleting bulk emails.

As for devices other than Jolla1, . . . . .YMMV.

Thanks to user wgs for the streamline code for the pulley menu, which meant I could use less code in the patch!.

Conversation on SFO;

    https://forum.sailfishos.org/t/3-4-0-22-ui-inconsistences-in-email-clien...

Screenshots: 

Category:

Keywords:

Application versions: 
AttachmentSizeDate
File sailfishos-patch-email-pulley-menu-0.1-1.noarch.rpm10.61 KB18/10/2020 - 14:02
File sailfishos-patch-email-pulley-menu-0.1-2.noarch.rpm10.82 KB19/10/2020 - 13:11
File sailfishos-patch-email-pulley-menu-0.1-3.noarch.rpm10.77 KB26/10/2020 - 19:01
Changelog: 

Version 0.1-2 - Fixes the deleting mail problem in main view

Version 0.1-3 fixes the blanking/fading problem with main view

Comments

DrYak's picture

DrYak

Wed, 2021/03/03 - 21:07

Hi, I love this patch. Of making a port to SFOS 4.0.1 Koli ?

Markkyboy's picture

Markkyboy

Thu, 2021/03/04 - 20:48

Hi, I'm still using Jolla1, so no SFOS 4 for me, as a result, I cannot update the patch, sorry :(

b100dian's picture

b100dian

Fri, 2021/10/08 - 23:45

The patch works on SFOS4, it just that PM3 can't patch sailjailed apps. PM3.1 is now available with this ability https://forum.sailfishos.org/t/patchmanager3-for-sailfishos-4/8549

martinbook85's picture

martinbook85

Wed, 2021/02/17 - 23:49

Great patch! Was using it on my Sailfish XA2 Ultra 3.4.. Loved having the pulley back in the e-mail app. Any thoughts about updating it to work on SFOS4?

b100dian's picture

b100dian

Fri, 2021/10/08 - 23:45

You need PM3.1 or later (see the link in the other comment)

Markkyboy's picture

Markkyboy

Thu, 2021/03/04 - 20:48

Hi, I'm still using Jolla1, so no SFOS 4 for me, as a result, I cannot update the patch, sorry :(

s_mario's picture

s_mario

Fri, 2020/10/23 - 17:24

Thanks for making the patch, tried it today.
On my Xperia X, I unfortunately have the same problem as PawelSpoon with transparency after clicking the fourth mail. And i noticed that the text of the pulley actions is in English. When I looked into the diff file I saw, that the texts are hard-coded there. I did some research.
May I make a suggestion? In addition to the change in the activation of the pulley proposed by the user wgs, and the code from yours hiding the Footer we would only have to include this part instead of the code for the entire pulley to make the delete function work.

        MessageViewPullDown {
                onRemoveRequested: view.removeRequested()
        }

I inserted this part after Line 197/198 also in the HtmlViewer.qml:

        VerticalScrollDecorator { color: Theme.highlightBackgroundColor }
        HorizontalScrollDecorator { color: Theme.highlightBackgroundColor }

        MessageViewPullDown {
                onRemoveRequested: view.removeRequested()
        }

 

Greetings

Markkyboy's picture

Markkyboy

Sun, 2020/10/25 - 13:08

Hello again s_mario,

your code snippet seems to be working. I'm testing now, playing with plain and html emails, deleting, moving around, back and forth of other accounts and so far, the fading problem is **not** occurring.......fingers crossed. I will play extensively before amending the patch. 

It stills seems strange to me that my second version of the patch took so many days to actually fail, I cannot fathom that at all. I'm also surprised that so few users have reported the same problem.

Regards,

s_mario's picture

s_mario

Mon, 2020/10/26 - 21:51

Don't worry, it will be ready when the time is right. Don't put yourself under such pressure ;-).

Kind regards.

 

Markkyboy's picture

Markkyboy

Tue, 2020/10/27 - 14:15

Updated. Should be okay now, at least on my Jolla1 device. I have fiddled about extensively and have yet to see any problems.....but maybe Xperia devices still have the problem?, which I cannot test as I don't own any such device. Let me know, thank you.

s_mario's picture

s_mario

Tue, 2020/10/27 - 15:50

Yes it works now also very well on my XperiaX.
Thx

Markkyboy's picture

Markkyboy

Fri, 2020/10/23 - 21:10

Hi, thanks for your input. I have little spare time at the moment, family, computer problems, car problems, etc. When I get 5 minutes, I'll play about some more. Sorry for the inconvenience.

japsi's picture

japsi

Wed, 2020/10/21 - 22:06

Yep, same problem but only with my Exchange work account, Gmail works fine. And what is more strange even in Exchange some mails do open just fine..

PawelSpoon's picture

PawelSpoon

Wed, 2020/10/21 - 07:39

It started suddenly yesterday: it breaks the view to become iall transparent. First i thought it is okboard, but it seems to be his patch. Xperia 10. View gets loaded, shorty you see some text, then it eitr disapperars or starts kinda blinking

Markkyboy's picture

Markkyboy

Wed, 2020/10/21 - 12:42

Yeah, strange. No problems until now. Then I saw your comment here, checked it out on my Jolla1 and sure enough, it did exactly what you said which basically crashes the email application in my case. I'm not sure where to start, removing, installing and reactivating the patch makes no difference and why after only a few days does a problem show.....weird, oh well, sorry, for now. If I find a fix, I will update the patch.

blizzz's picture

blizzz

Mon, 2020/10/19 - 19:32

Thank you :)

japsi's picture

japsi

Mon, 2020/10/19 - 14:23

Fixed version works, great work!

fooxl's picture

fooxl

Mon, 2020/10/19 - 14:11

Hi,

I'm new to using patches. Why isn't this one showing up in patchmanager 3.0 (using Xperia X)?

Thanks for your help.

Markkyboy's picture

Markkyboy

Mon, 2020/10/19 - 14:18

I've noticed this, it happens on my device, but not always. I thought it was a problem with patchmanager, but coderus says it is not.

I have found sometimes I need to select 'Unapply patches' from Patchmanager pulley menu and then the patch appears and can be applied..

japsi's picture

japsi

Mon, 2020/10/19 - 11:00

It kind of works on Xperia XA2 dual SIM. Meaning pulley menu is there and "Reply" and "Forward" seems to work but "Delete" doesn't. Just goes back to e-mail list.

Markkyboy's picture

Markkyboy

Mon, 2020/10/19 - 13:12

Fixed in version 0.1-2
Try it, let me know, thanks

Markkyboy's picture

Markkyboy

Mon, 2020/10/19 - 12:55

Indeed, well spotted, I'll look into it.

Erdrandbewohner's picture

Erdrandbewohner

Sun, 2020/10/18 - 16:00

Great! It works fine on my Xperia 10 Dualsim! Thank You!

Markkyboy's picture

Markkyboy

Sun, 2020/10/18 - 16:28

Good to know, thanks for reporting :)

Historyscholar's picture

Historyscholar

Sun, 2020/10/18 - 15:23

It works on Xperia 10 Plus.Thanks.

Markkyboy's picture

Markkyboy

Sun, 2020/10/18 - 16:29

Good to know, thanks for reporting :)